Skip to content

chore(e2e): Add local E2E action to check workflow #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore(e2e): Add local E2E action to check workflow #971

wants to merge 3 commits into from

Conversation

sommeeeer
Copy link
Contributor

@sommeeeer sommeeeer commented Aug 31, 2025 •
edited
Loading

This PR will be the last missing piece for running the E2E locally in our Validate merge requests workflow.

  • It will replace our current Playwright setup with its own action. The one we currently have had some error in its syntax, resulting in never providing a value to its output. Thus, it would never be cached. However, Playwright themselves do claim that you should not really cache. Let me know if I should change that.
  • It will build and run all the examples/* apps on these ports: app-router=3001 pages-router=3002 app-pages-router=3003 experimental=3004. The command it uses is pnpm -r openbuild:local to build and openbuild:local:start to start the servers.
  • After that it will run pnpm e2e:test

I also renamed the pnpm-setup action to setup.

Here is a successful run on my fork (with the pending PRs)

Depends on #964 and #970

For this #958 (comment)

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 31, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1cda2e7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sommeeeer sommeeeer changed the title chore(e2e): Add e2e-local action to check workflow chore(e2e): Add local E2E action to check workflow Aug 31, 2025
@sommeeeer
chore(e2e): Add e2e-local action to check workflow
c2f86f4 
fix order

refactor check workflow order

fs-dev-nextMode for experimental

refactor env variable
@sommeeeer sommeeeer marked this pull request as ready for review August 31, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sommeeeer